Skip to content

PyInt.ToString returns wrong strings for values between 128 and 256 #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rmadsen-ks opened this issue Oct 28, 2022 · 0 comments · Fixed by #1993
Closed

PyInt.ToString returns wrong strings for values between 128 and 256 #1990

rmadsen-ks opened this issue Oct 28, 2022 · 0 comments · Fixed by #1993
Labels
bug

Comments

@rmadsen-ks
Copy link
Contributor

rmadsen-ks commented Oct 28, 2022 •
edited
Loading

Environment

  • Pythonnet version: 3.0.0-rc6
  • Python version: 3.7
  • Operating System: Windows 10
  • .NET Runtime: .net 6

This test fails with error -56 != 200

def test_object_string_format():
    """Test int to string."""
    from System import String
    integer_value = 200
    string_value = String.Format("{0}", integer_value)
    assert string_value == "200", f"{string_value} != ""200"""

Solution coming up
@filmor filmor added the bug label Oct 28, 2022
@rmadsen-ks rmadsen-ks mentioned this issue Oct 28, 2022
Closed
5 tasks
lostmsu added a commit to losttech/pythonnet that referenced this issue Oct 28, 2022
@lostmsu
fixed positive PyInt converted to negative BigInteger
a8db175 
BigInteger constructor uses the sign bit in the first byte. Since we explicitly handle the sign, the fix is to prepend a zero byte to the number, which does not change it, but ensures sign bit is zero.

fixes pythonnet#1990
lostmsu added a commit to losttech/pythonnet that referenced this issue Oct 28, 2022
@lostmsu
fixed positive PyInt converted to negative BigInteger
218610e 
BigInteger constructor uses the sign bit in the first byte. Since we explicitly handle the sign, the fix is to prepend a zero byte to the number, which does not change it, but ensures sign bit is zero.

fixes pythonnet#1990
@lostmsu lostmsu mentioned this issue Oct 28, 2022
Merged
2 tasks
elan-ajain pushed a commit to elancapital/pythonnet that referenced this issue Feb 17, 2023
@lostmsu @elan-ajain
fixed positive PyInt converted to negative BigInteger
d01e4b8 
BigInteger constructor uses the sign bit in the first byte. Since we explicitly handle the sign, the fix is to prepend a zero byte to the number, which does not change it, but ensures sign bit is zero.

fixes pythonnet#1990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@filmor @rmadsen-ks