Skip to content

Should we move setup.py to the root folder? #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidanthoff opened this issue Apr 10, 2014 · 3 comments
Closed

Should we move setup.py to the root folder? #40

davidanthoff opened this issue Apr 10, 2014 · 3 comments
Assignees
@tonyroberts
Milestone
2.0.0

Comments

@davidanthoff
Copy link
Contributor

It seems that is the customary place for it.

It would potentially allow installation of the current dev version via pip (http://www.pip-installer.org/en/latest/reference/pip_install.html#git), i.e. without a manual download.

If we do want to move it, it would probably make sense to first move it to root and then do #25.
@davidanthoff davidanthoff added this to the 2.0.0 Beta 1 milestone Apr 10, 2014
@tonyroberts
Copy link
Contributor

Maybe we should just move everything from the pythonnet folder into the root?

@davidanthoff
Copy link
Contributor Author

Yep, good idea. I can do that :) Are you ok if I do this now? Just want to make sure you don't have some big other PR coming that still relies on the old directory structure.

@tonyroberts
Copy link
Contributor

Cool. Nope, now the unit tests are passing I don't anticipate making too many more changes until after we've got the release done :)

On Apr 11, 2014, at 7:50 PM, David Anthoff notifications@github.com wrote:

Yep, good idea. I can do that :) Are you ok if I do this now? Just want to make sure you don't have some big other PR coming that still relies on the old directory structure.

—
Reply to this email directly or view it on GitHub.

@davidanthoff davidanthoff mentioned this issue Apr 11, 2014
Merged
@alhad-deshpande alhad-deshpande mentioned this issue Jul 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyroberts tonyroberts

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@davidanthoff @tonyroberts