You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe what you were trying to get done.
Just code review.
file: runtime.cs, line ~281
#if PYTHON3IntPtrdllLocal=IntPtr.Zero;if(PythonDll!="__Internal"){// Current. !!!!!!! BUG HERE !!!!!!!NativeMethods.LoadLibrary(PythonDll);// Brobably correct versiondllLocal=NativeMethods.LoadLibrary(PythonDll);}_PyObject_NextNotImplemented=NativeMethods.GetProcAddress(dllLocal,"_PyObject_NextNotImplemented");
#if !(MONO_LINUX||MONO_OSX)if(dllLocal!=IntPtr.Zero){// Another !!!! BUG !!!// _PyObject_NextNotImplemented - Pointer can stay invalid after Library dispose.// This code will be valid only if Windows preserve proc addresses on each DLL load// But it can be changed. For example Win7 x86 = ok, Win10 x64 = oops, addresses drift.NativeMethods.FreeLibrary(dllLocal);}
#endif
#endif
The text was updated successfully, but these errors were encountered:
Is this actually causing you an issue? I looked into this too a while back and couldn't make it produce an error even though the syntax looks wrong. If I remember right 'dllLocal' ends up getting assigned in Linux but not on windows.
Since I couldn't reproduce an actual bug I left the code as is.
Uh oh!
There was an error while loading. Please reload this page.
Environment
Almost any.
Details
Probably bugs in the source code.
Just code review.
file: runtime.cs, line ~281
The text was updated successfully, but these errors were encountered: