Added Python 3.5 Support #104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,6 +51,7 @@ | |||
| <PlatformTarget>x64</PlatformTarget> | |||
| <CodeAnalysisIgnoreBuiltInRuleSets>false</CodeAnalysisIgnoreBuiltInRuleSets> | |||
| <CodeAnalysisIgnoreBuiltInRules>true</CodeAnalysisIgnoreBuiltInRules> | |||
| <DefineConstants>PYTHON35, UCS2</DefineConstants> | |||
There was a problem hiding this comment.
This needs to be guarded with a condition on DefineConstants not being already set. Otherwise the ReleaseWin|x64 target will always try and build the Python 3.5 build, regardless of the settings passed in via setup.py.
This line can probably just be removed (see line 47 just above here).
|
@brisingraerowing thanks very much for doing this. I've added a few comments to the code for you to look at. In addition, I think it would be good to add 3.5 to the travis and appveyor CI builds and run the unit tests before we integrate this. |
Closed
|
Why was this closed? |
|
How can this unknown branch get forked to continue Python 3.5 work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added preliminary Python 3.5 support. A quick test (getting some properties from the System.Environment class) worked perfectly fine on Windows 10 x64 with Python 3.5.0 amd64.