Skip to content

Reduce perf iterations further to keep up with BenchmarkDotNet autotuning #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Feb 21, 2020

BenchmarkDotNet tuned the number of runs up to keep the total perf tests run time high. This reduces the number of runs per test further, which allows BenchmarkDotNet to do more runs of a smaller test to collect more information for better statistical results.

@lostmsu
Copy link
Member Author

lostmsu commented Feb 21, 2020

This still affects #1050

@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

Merging #1053 into master will decrease coverage by 14.9%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1053       +/-   ##
===========================================
- Coverage   86.42%   71.52%   -14.91%     
===========================================
  Files           1        1               
  Lines         302      302               
===========================================
- Hits          261      216       -45     
- Misses         41       86       +45
Flag Coverage Δ
#setup_linux 100% <ø> (+35.09%) ⬆️
#setup_windows 71.52% <ø> (ø) ⬆️
Impacted Files Coverage Δ
setup.py 71.52% <0%> (-14.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb8436...7034390. Read the comment docs.

@lostmsu lostmsu merged commit 6236806 into pythonnet:master Feb 22, 2020
@lostmsu lostmsu deleted the PR/AppVeyorTimings branch February 27, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants