Update test dependencies to the latest stable versions #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2dd50a to
2362c22
Compare
2362c22 to
92533c5
Compare
fff7bf0 to
28e179e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
- Coverage 86.75% 65.56% -21.2%
==========================================
Files 1 1
Lines 302 302
==========================================
- Hits 262 198 -64
- Misses 40 104 +64
Continue to review full report at Codecov.
|
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 29, 2020
* update test dependencies to the latest stable versions * print C# embed test names as they run in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My investigation of memory dump from #1050 (comment) did not reveal anything, that could be clearly caused by our code. The only thread, that runs our C# code is the one making the memory dump, and it is properly marked as
IsBackground = true, so NUnit should ignore it.If we upgrade our test dependencies to their latest supported versions, NUnit team would help us debug test execution deadlock. Alternatively upgrade might just solve the issue.
P.S. No need to review until CI passes for this PR, as I am unsure which test library configurations CI will support yet.