Skip to content

Disable 3.8 tests in AppVeyor, as they never pass yet anyway #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2020

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Feb 23, 2020

Subj

@codecov-io
Copy link

codecov-io commented Feb 23, 2020

Codecov Report

Merging #1058 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1058   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files           1        1           
  Lines         302      302           
=======================================
  Hits          262      262           
  Misses         40       40
Flag Coverage Δ
#setup_linux 65.56% <ø> (ø) ⬆️
#setup_windows 71.52% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6236806...7874388. Read the comment docs.

@filmor
Copy link
Member

filmor commented Feb 26, 2020

What for? As they are allowed failures, we can just keep them until we have actually fixed the tests.

@filmor filmor closed this Feb 26, 2020
@lostmsu
Copy link
Member Author

lostmsu commented Feb 26, 2020

@filmor they take extra ~20 minutes to run.

@filmor
Copy link
Member

filmor commented Feb 26, 2020

Hmm, good point...

@lostmsu
Copy link
Member Author

lostmsu commented Feb 27, 2020

I am reopening this, as it also affects attempts to rerun CI where a single leg randomly failed, as it always reruns all 3.8 in addition to that, turning a 5 min job into 25 min job.

@lostmsu lostmsu reopened this Feb 27, 2020
@filmor
Copy link
Member

filmor commented Feb 29, 2020

Okay, let's do this for now. Linking #1066 for reference.

@filmor filmor merged commit 8e108b4 into pythonnet:master Feb 29, 2020
AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants