Fixed reference counting for exception objects in Py.With #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyObject(s) constructed for __exit__ method referenced existing Python objects without increasing refcount appropriately, which could lead to double-free.
Codecov Report
@@ Coverage Diff @@
## master #1062 +/- ##
==========================================
+ Coverage 86.42% 86.75% +0.33%
==========================================
Files 1 1
Lines 302 302
==========================================
+ Hits 261 262 +1
+ Misses 41 40 -1
Continue to review full report at Codecov.
|
filmor
approved these changes
Feb 26, 2020
This was referenced Feb 26, 2020
|
I just wanted to comment on here to tell you that I ran into this issue and this PR was the root cause. We had some python exceptions being fired within a Thanks! |
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 29, 2020
…1062) PyObject(s) constructed for __exit__ method referenced existing Python objects without increasing refcount appropriately, which could lead to double-free.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
PyObjects constructed for__exit__method referenced existing Python objects without increasing refcount appropriately, which could lead to double-free.Does this close any currently open issues?
Not sure, but this issue might have been one of the possible causes for #1050