Explorarion of the new *Reference types: reimplemented some of the PyList members using BorrowedReference #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmor
approved these changes
Mar 3, 2020
|
@lostmsu Still needs, because I need to put them into collection and return somewhere. That's why I suggest making them copyable before. |
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just playing with the new *Reference types to see what patterns might arise.
This adds:
PyObject.Referenceinternal property, that exposes the same pointer asobj, but in a way, that it is clear, that the reference is borrowedPyObject(BorrowedReference)constructor, that extracts the address from the reference andIncRefs it before storing in the instancePyList_*methods now explicitly takeBorrowedReferenceinstead of raw pointers