Allow borrowing from NewReference #1088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implemented as an implicit conversion
Codecov Report
@@ Coverage Diff @@
## master #1088 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 1 1
Lines 302 302
=======================================
Hits 262 262
Misses 40 40
Continue to review full report at Codecov.
|
|
@amos402 can you review this? |
amos402
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented as an implicit conversion
To be honest, I would prefer an explicit
NewReference.Borrow()method due to "explicit is better than implicit" motto. The only problem with implicit conversion that I see isnew PyObject(newRef)will call an extra incref implicitly as opposed tonewRef.MoveToPyObject(), and will go unnoticed.Another thing to consider is having a
null-check in the conversion. E.g. should we throwNullReferenceExceptionifNewReferenceisnull?Does this close any currently open issues?
Related to #1087
Checklist
Check all those that are applicable and complete.