Skip to content

Update vswhere usage #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2020
Merged

Update vswhere usage #1105

merged 2 commits into from
Apr 9, 2020

Conversation

slide
Copy link
Contributor

@slide slide commented Apr 8, 2020

Updates to newer version of vswhere.exe

Follows the recommended way of finding MSBuild.exe from https://github.com/microsoft/vswhere#example

Also, updates to allow finding newer versions of VS.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

slide added 2 commits April 7, 2020 17:17
@slide
Update vswhere usage
51b857b 
Updates to newer version of vswhere.exe

Follows the recommended way of finding MSBuild.exe
from https://github.com/microsoft/vswhere#example

Also, updates to allow finding newer versions of VS.
@slide
Add CHANGELOG entry
152a018
@lostmsu lostmsu merged commit 2a83fe5 into pythonnet:master Apr 9, 2020
AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull request Jun 29, 2020
@slide @AlexCatarino
Update vswhere usage (pythonnet#1105)
14be2ca 
Updates to newer version of vswhere.exe

Follows the recommended way of finding MSBuild.exe
from https://github.com/microsoft/vswhere#example

Also, updates to allow finding newer versions of VS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slide @lostmsu