Improve "No constructor matches given arguments" message with more details #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tails Similar to pythonnet#900, but for constructors (reuses the same code) Related issues: pythonnet#811, pythonnet#265, pythonnet#1116
Codecov Report
@@ Coverage Diff @@
## master #1143 +/- ##
=======================================
Coverage 86.66% 86.66%
=======================================
Files 1 1
Lines 300 300
=======================================
Hits 260 260
Misses 40 40
Continue to review full report at Codecov.
|
filmor
reviewed
May 14, 2020
| var description = Runtime.PyObject_Unicode(type); | ||
| if (description != IntPtr.Zero) | ||
| { | ||
| to.Append(Runtime.GetManagedString(description)); |
There was a problem hiding this comment.
If GetManagedString fails, you leak description
There was a problem hiding this comment.
Ah, but I see that is not your doing but was already in the code...
There was a problem hiding this comment.
@filmor it is still my doing :-D
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 29, 2020
…tails (pythonnet#1143) Similar to pythonnet#900, but for constructors (reuses the same code) Related issues: pythonnet#811, pythonnet#265, pythonnet#1116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #900, but for constructors (reuses the same code moved around)
What does this implement/fix? Explain your changes.
This adds more details to "No constructor matches given arguments" message.
Was
Now
Does this close any currently open issues?
Does not close any issue, but is related to: #811, #265, #1116