Convert projects to SDK style #1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's see the build results. If we take this, would need a tracking task for reestablishing testing on Mono. |
lostmsu
reviewed
Aug 25, 2020
fbc0376 to
dff8dbe
Compare
- Convert tests to SDK style - Delete obsolete files and add common build props - Convert Runtime to SDK style and always use .NET Standard - Convert console to SDK style - Convert clrmodule to SDK style and switch to NXPorts
0d3ce21 to
fc6c529
Compare
|
There are two tests failing right now, both variants of |
- Build tests explicitly - Build test fixtures from the pytest call - Run tests with dotnet test - Reset solution file - Always run full test matrix Note: Newer .NET runs Mono tests as well as .NET Core tests if both target frameworks are defined.
5d3a26c to
640b497
Compare
|
With the deactivated test, it seems to work now. Not entirely reliably, though. I had some failures in the finalisation. |
lostmsu
reviewed
Dec 9, 2020
This was referenced Dec 9, 2020
filmor
commented
Dec 10, 2020
|
This is done from my side. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt, splitting up the conversion to a more modern style even further. This is just supposed to convert the project files and keep the existing loading for now (leaving the new loader for a separate PR based on #1109).