Skip to content

Update setup.py #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2016
Merged

Update setup.py #121

merged 2 commits into from
Jan 28, 2016

Conversation

den-run-ai
Copy link
Contributor

  1. PythonBuildDir should have quotes around directories with spaces
  2. Microsoft has released a special trimmed Python 2.7 C++ Compiler and Tools.
  3. Attach mechanism for debugging build/installation with ptvsd (commented out)

@den-run-ai
Copy link
Contributor Author

@tonyroberts BTW, the python setup.py install builds and installs pythonnet as egg and puts Python.Runtime.dll into wrong directory. The wheel version is fine (python setup.py bdist_wheel).

@den-run-ai
Copy link
Contributor Author

AppVeyor fails:

Build started
git clone -q https://github.com/pythonnet/pythonnet.git C:\projects\pythonnet
git fetch -q origin +refs/pull/121/merge:
git checkout -qf FETCH_HEAD
Running Install scripts
(new-object net.webclient).DownloadFile($env:pythonurl, 'C:\python.msi')
start-process -wait -FilePath msiexec.exe -ArgumentList "/qn /i C:\python.msi TARGETDIR=C:\Python"
(new-object net.webclient).DownloadFile('https://raw.github.com/pypa/pip/master/contrib/get-pip.py', 'C:\get-pip.py')
if ($env:pythonurl -eq "http://www.python.org/ftp/python/2.7.6/python-2.7.6.msi") {mi c:\python27 c:\python}
set PATH=C:\Python;%PATH%
C:\Python\python.exe c:\get-pip.py
You're using an outdated location for the get-pip.py script, please use the one available from https://bootstrap.pypa.io/get-pip.py
Command exited with code 1

@tonyroberts
Copy link
Contributor

@denfromufa look good, thanks. Could you just remove the commented out code from the start of the file though please?

@den-run-ai
Copy link
Contributor Author

@tonyroberts sure, done.

tonyroberts added a commit that referenced this pull request Jan 28, 2016
@tonyroberts
Merge pull request #121 from denfromufa/develop
76ef774 
Update setup.py
@tonyroberts tonyroberts merged commit 76ef774 into pythonnet:develop Jan 28, 2016
@tonyroberts
Copy link
Contributor

The appveyor jobs are a bit broken at the moment... I had a look at fixing them in my fork but haven't had enough time to move that across to here yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@den-run-ai @tonyroberts