Skip to content

fix wrongly cased Microsoft.CSHARP.Targets #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2020
Merged

fix wrongly cased Microsoft.CSHARP.Targets #1271

merged 1 commit into from
Nov 3, 2020

Conversation

vivainio
Copy link
Contributor

@vivainio vivainio commented Nov 2, 2020 •
edited
Loading

What does this implement/fix? Explain your changes.

"dotnet msbuild pythonnet.sln" fails in WSL2 because .targets files are wrongly cased, and Linux is case sensitive.

The command still fails, but at least for different error :).

@dnfadmin
Copy link

dnfadmin commented Nov 2, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@vivainio
Copy link
Contributor Author

vivainio commented Nov 2, 2020

For reference, current error is:

/usr/share/dotnet/sdk/3.1.403/Microsoft.Common.CurrentVersion.targets(1177,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.0 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [/mnt/c/p/pythonnet/src/embed_tests/Python.EmbeddingTest.csproj]
/usr/share/dotnet/sdk/3.1.403/Microsoft.Common.CurrentVersion.targets(1177,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.0 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [/mnt/c/p/pythonnet/src/testing/Python.Test.csproj]
/usr/share/dotnet/sdk/3.1.403/Microsoft.Common.CurrentVersion.targets(1177,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.0 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [/mnt/c/p/pythonnet/src/console/Console.csproj]
/usr/share/dotnet/sdk/3.1.403/Microsoft.Common.CurrentVersion.targets(1177,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.0 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [/mnt/c/p/pythonnet/src/runtime/Python.Runtime.csproj]
v@B9DPGH2:/mnt/c/p/pythonnet$

@lostmsu
Copy link
Member

lostmsu commented Nov 2, 2020 •
edited
Loading

@vivainio pythonnet.sln is a legacy solution. Please, use pythonnet.15.sln for .NET Core

@vivainio
Copy link
Contributor Author

vivainio commented Nov 3, 2020

@lostmsu ok, the fix is is csproj files so it doesn't matter.

"dotnet msbuild pythonnet.15.sln" fails similarly, but I 'm not sure it's even supposed to work with Linux yet.

@lostmsu lostmsu merged commit 84e2735 into pythonnet:master Nov 3, 2020
@vivainio vivainio deleted the fix-cases branch November 3, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivainio @dnfadmin @lostmsu