Skip to content

Dropped net40 target from modern projects #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Nov 30, 2020

What does this implement/fix? Explain your changes.

This drops support for .NET Framework 4.0 - 4.6.0. Python.NET will now require .NET Framework 4.6.1+

Does this close any currently open issues?

#1299

Any other comments?

Also removed dead targets for Python 2.X support

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@lostmsu lostmsu force-pushed the NetStandard branch 4 times, most recently from 48cfa55 to aa20659 Compare November 30, 2020 23:28
@codecov-io
Copy link

codecov-io commented Dec 1, 2020

Codecov Report

Merging #1300 (aa20659) into master (ab97b02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1300   +/-   ##
=======================================
  Coverage   87.88%   87.88%           
=======================================
  Files           1        1           
  Lines         289      289           
=======================================
  Hits          254      254           
  Misses         35       35           
Flag Coverage Δ
setup_linux 65.05% <ø> (ø)
setup_windows 74.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab97b02...aa20659. Read the comment docs.

@lostmsu lostmsu marked this pull request as ready for review December 1, 2020 00:47
@lostmsu
Copy link
Member Author

lostmsu commented Dec 1, 2020

Close + reopen to pick up on Travis

@lostmsu lostmsu closed this Dec 1, 2020
@lostmsu lostmsu reopened this Dec 1, 2020
@filmor
Copy link
Member

filmor commented Dec 1, 2020

While I agree with the general sentiment of this PR, I'd like to just land my SDK-style project branch in the next week. It includes this change but changes all of the project files, so this would just lead to a lot of merge conflicts.

@lostmsu
Copy link
Member Author

lostmsu commented Dec 9, 2020

I will simply rebase my later changes on master once #1209 lands

@lostmsu lostmsu closed this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants