Monthly NuGet release previews #1380
Conversation
|
Does this really need to run tests? IMHO it's perfectly fine to keep this as simple as possible, i.e. to just run |
a1232da to
7c205d6
Compare
|
I think it is better to keep tests to avoid non-functional releases. |
7c205d6 to
588f49b
Compare
| @@ -38,6 +38,9 @@ indent_style = tab | |||
| charset = utf-8 | |||
| insert_final_newline = true | |||
|
|
|||
| [Python.Runtime.csproj] | |||
| charset = latin1 | |||
There was a problem hiding this comment.
This is an odd choice for XML, is this intentional?
There was a problem hiding this comment.
Without this Visual Studio tends to add UTF-8 BOM header to solution, leading to PRs with the entire file replaced. It simply ignores utf-8 above.
.github/workflows/nuget-preview.yml
Outdated
| - name: Publish NuGet | ||
| run: dotnet nuget push --api-key ${NUGET_KEY} | ||
| env: | ||
| NUGET_KEY: ${{ secrets.NUGET_MONTHLY }} |
There was a problem hiding this comment.
I think this way you'll leak the key.
There was a problem hiding this comment.
I don't think so, but the reason I had to try to add this turned out to be bogus: it was not picked up, because PR was from my fork. I moved the PR branch into this repository instead, now it is getting picked up correctly. See #1381
So I reverted to using ${{ secrets.NUGET_MONTHLY }} directly
588f49b to
aae2c4d
Compare
|
Superseded by #1381 |
What does this implement/fix? Explain your changes.
This generates monthly release previews on NuGet using GitHub actions
Does this close any currently open issues?
#1379