Skip to content

Finalizer Fixes #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Finalizer Fixes #1383

wants to merge 2 commits into from

Conversation

filmor
Copy link
Member

@filmor filmor commented Feb 14, 2021

What does this implement/fix? Explain your changes.

During the implementation of #1373, a couple of errors surfaced when activating a proper shutdown. This PR tries to improve the situation such that finally, we can unconditionally activate the proper shutdown.

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@amos402
Copy link
Member

amos402 commented Feb 19, 2021

Partial fix in #1267 on 958a8eb
Still have some troubles with (macos, 3.8, x64, Soft).

@filmor filmor closed this Dec 15, 2021
@filmor filmor deleted the finalizer-fixes branch November 9, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants