Remove Utf8Marshaler, set PyScope base class to PyObject, added PyModule #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbfd65c to
ad5343d
Compare
filmor
reviewed
Feb 22, 2021
filmor
reviewed
Feb 22, 2021
filmor
reviewed
Feb 22, 2021
filmor
reviewed
Feb 22, 2021
ad5343d to
86a4081
Compare
filmor
reviewed
Feb 24, 2021
src/runtime/pythonengine.cs
Outdated
| @@ -742,9 +707,10 @@ public static KeywordArguments kw(params object[] kv) | |||
| return dict; | |||
| } | |||
|
|
|||
| [Obsolete("Use PyModule.Import")] | |||
| public static PyObject Import(string name) | |||
There was a problem hiding this comment.
I wouldn't obsolete this one right now. Having Py. as a central entry-point has merit.
There was a problem hiding this comment.
@filmor Perhaps we should move Py class into its own file 🤣
There was a problem hiding this comment.
:D
Yep, sorry for the inconsistency. I'd like to obsolete PythonEngine for the most part and collect entry points in Py.
There was a problem hiding this comment.
Removed this [Obsolete], added a new issue to move Py out.
changed PyScope to inherit from PyObject
86a4081 to
ac68aab
Compare
08609b9 to
ac68aab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allow
BorrowedReference == nullcomparison.