Skip to content

Fix exception refcnt #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Fix exception refcnt #1402

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee30c94
Fix a ref count issue in PythonException
BadSingleton Feb 11, 2021
480a549
Fixes a leak in ExceptionClassObject
BadSingleton Feb 26, 2021
5ea9c3c
Code review fixes
BadSingleton Mar 4, 2021
891ad8c
code review fixes
BadSingleton Mar 5, 2021
d180f2a
kick the build
BadSingleton Mar 8, 2021
47290ee
kick the build, again
BadSingleton Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix a ref count issue in PythonException
  • Loading branch information
@BadSingleton
BadSingleton committed Feb 26, 2021
commit ee30c94a5814150fb94d0892f5d909d102dc7b55
9 changes: 9 additions & 0 deletions src/runtime/pythonexception.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,16 @@ public void Normalize()
{
if (Exceptions.ErrorOccurred()) throw new InvalidOperationException("Cannot normalize when an error is set");
// If an error is set and this PythonException is unnormalized, the error will be cleared and the PythonException will be replaced by a different error.
IntPtr oldValue = _pyValue;
Runtime.PyErr_NormalizeException(ref _pyType, ref _pyValue, ref _pyTB);

if (_pyValue != oldValue)
{
// we own the reference to _pyValue, so make adjustments if it changed.
// Disown old, own new
Runtime.XDecref(oldValue);
Runtime.XIncref(_pyValue);
}
}
finally
{
Expand Down