Re-enable the domain reload tests #1404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `src/domain_tests` to `testpaths` in pyproject.toml
|
Sorry about that. Could you please add these as separate actions, though, instead of adding them to the normal testing? They are only relevant on Mono and .NET Framework anyhow. |
|
I think adding them as a separate action is not optimal, as devs will have to run pytest specifying explicitly the domain tests. I added pytest filtering instead |
|
I think the timeouts are false positive. The domain tests takes about 1:15m to execute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1403
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG