Skip to content

Removed unnecessary dictionary initialization in CLRObject #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Removed unnecessary dictionary initialization in CLRObject #1413

wants to merge 0 commits into from

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Mar 10, 2021 •
edited
Loading

I don't see any reason for it to be present. The code does not have any associated comments, and I was not able to hit it running our tests. Any proper access to ob_dict should be going through PyObject_GenericGetDict, which initializes ob_dict if necessary.

@lostmsu lostmsu marked this pull request as ready for review March 10, 2021 02:42
@lostmsu lostmsu closed this May 3, 2021
@lostmsu lostmsu force-pushed the dont-alloc-dict-for-clrobject branch from 66ddf97 to db746aa Compare May 3, 2021 06:45
@lostmsu
Copy link
Member Author

lostmsu commented May 3, 2021

Superseded by #1441

@lostmsu lostmsu deleted the dont-alloc-dict-for-clrobject branch May 3, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lostmsu