Prevent stack overflow when an encoder is registered from Python #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3208bd2 to
aa5e504
Compare
(stack overflow trying to pass `System.Type` to `CanEncode`)
Without this restriction encoders created in Python cause stack overflow due to repeated attempts to pass `System.Type` instance to `CanDecode`, which requires encoding the instance of `System.Type`, et. cetera fixes pythonnet#1427
6b87b38 to
8045b5f
Compare
… to known issue with custom codes + engine restarts pythonnet#1256
8045b5f to
0d33a90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This disables ability to register encoders for
System.Type.Without this restriction encoders created in Python cause stack overflow due to repeated attempts to pass
System.Typeinstance toCanDecode, which requires encoding the instance ofSystem.Type.Does this close any currently open issues?
#1427
Checklist
Check all those that are applicable and complete.
CHANGELOG