Do not call find_libpython during import clr as Python.Runtime can find it on its own
#1440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, let's try it like this. I'll create a follow-up PR to make the CI use the (now adjusted) upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
find_libpythonspectacularly fails to find libpython for debug build of Python on latest Ubuntu (e.g.apt install python3-dbg; python3-dbg). It is also not necessary at runtime, sincePython.Runtimecan now find C API functions, since they are already loaded into the process.Does this close any currently open issues?
Probably these:
#1388
#1412 (partially)