Handle ProcessExit event #1458
Merged
Handle ProcessExit event #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmor
reviewed
May 22, 2021
| @@ -393,6 +393,10 @@ internal static void Shutdown(ShutdownMode mode) | |||
| { | |||
| Py_Finalize(); | |||
| } | |||
| else | |||
| { | |||
| PyGILState_Release(state); | |||
There was a problem hiding this comment.
This change seems unrelated, why did you add this?
There was a problem hiding this comment.
Without this Py_Finalize called when Python finally shuts down hangs because it can't acquire GIL.
|
I debugged the test failures, and they appear to be caused by gaps in domain reload support: when .NET objects that Python sees get severed from CLR, subsequent calls to their |
…r Mono) is unloaded before Python stops
914ff18 to
366f548
Compare
|
Found a way to solve the same problem and more without handling |
|
Or maybe not. Seems to still be essential for #1134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids segfault when CLR (in particular Mono) is unloaded before Python stops.
What does this implement/fix? Explain your changes.
AppDomain.ProcessExit, that fires in the situations like this instead ofAppDomain.DomainUnload. This allows Python.NET to remove all slots, that are implemented in C#.Does this close any currently open issues?
This is (at least one of) the reason of CI test crashes in #1134