Skip to content

Added workaround for warning in threading module after TestInterrupt #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Sep 22, 2021

Also: avoid using dynamic in GetPythonThreadID

What does this implement/fix? Explain your changes.

This should put us to peace in regards to this warning in CI on MacOS X Python 3.7:

Exception ignored in: <module 'threading' from '/Users/runner/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/threading.py'>
Traceback (most recent call last):
  File "/Users/runner/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/threading.py", line 1292, in _shutdown
    assert tlock.locked()
AssertionError: 

It happens when the main Python thread never imports threading module, while secondary threads do.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change

@lostmsu lostmsu merged commit 8fb4704 into pythonnet:master Sep 22, 2021
@lostmsu lostmsu deleted the interrupt-improvements branch September 22, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant