Skip to content

ClassManager illegally decrefed ClassObject's refcount on shutdown #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021
Merged

ClassManager illegally decrefed ClassObject's refcount on shutdown #1563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ClassManager illegally decrefed ClassObject's refcount on shutdown 
addresses #1561
  • Loading branch information
@lostmsu
lostmsu committed Sep 22, 2021
commit 9616a6f8774380bfe1ceb663365230357475c9fb
18 changes: 18 additions & 0 deletions src/embed_tests/pyinitialize.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,22 @@ public static void LoadSpecificArgs()
}
}

// regression test for https://github.com/pythonnet/pythonnet/issues/1561
[Test]
public void ImportClassShutdownRefcount()
{
PythonEngine.Initialize();

PyObject ns = Py.Import(typeof(ImportClassShutdownRefcountClass).Namespace);
PyObject cls = ns.GetAttr(nameof(ImportClassShutdownRefcountClass));
ns.Dispose();

Assert.Less(cls.Refcount, 256);

PythonEngine.Shutdown();
Assert.Greater(cls.Refcount, 0);
}

/// <summary>
/// Failing test demonstrating current issue with OverflowException (#376)
/// and ArgumentException issue after that one is fixed.
Expand Down Expand Up @@ -182,4 +198,6 @@ public static void TestRunExitFuncs()
Assert.True(called);
}
}

public class ImportClassShutdownRefcountClass { }
}
1 change: 0 additions & 1 deletion src/runtime/classmanager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ internal static void DisposePythonWrappersForClrTypes()
// since others may still referencing it.
cls.CallTypeTraverse(TraverseTypeClear, visitedPtr);
cls.CallTypeClear();
cls.DecrRefCount();
}
}
finally
Expand Down