Fixed FileLoadException when trying clr.AddReference('/full/path.dll')
#1573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c33d22 to
ebb5772
Compare
…/path.dll') Before trying to load an assembly by its full path we were trying to call `Assembly.Load` on it. `Assembly.Load` interprets its argument as a valid `AssemblyName`. However full paths are not valid assembly names, so that call would throw `FileLoadException`, which we did not handle. reported in pythonnet@9d5f579#commitcomment-57061082 Related: pythonnet#1514
ebb5772 to
5e68b16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Before trying to load an assembly by its full path we were trying to call
Assembly.Loadon it.Assembly.Loadinterprets its argument as a validAssemblyName. However full paths are not valid assembly names, so that call would throwFileLoadException, which we did not handle.The fix is to separately try to parse input string into an
AssemblyNameand only tryAssembly.Loadwhen it succeeds.Does this close any currently open issues?
9d5f579#commitcomment-57061082
Any other comments?
Related: #1514