Raise BadPythonDllException
instead of confusing TypeLoadException
when PythonDLL
was not configured properly
#1577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This handles failure to load internal
Delegates
type due to misconfiguredPythonDLL
, which used to raiseTypeLoadException
whoseInnerException
would give users the details. Unfortunately, some users do not bother to go as far as to look into theInnerException
, and instead go straight to GitHub and report "a bug".This change handles that
TypeLoadException
and rethrows it asBadPythonDllException
in major entry points, which makes looking intoInnerException
unnecessary, hopefully reducing the number of "bugs"Checklist
Check all those that are applicable and complete.
AUTHORS
CHANGELOG