Skip to content

Fix enum codec #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2022
Merged

Fix enum codec #1621

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df3b569
Fix enum codec
filmor Nov 23, 2021
4f070f2
Add unit test for enum encoder
filmor May 4, 2022
7d6e27a
Allow conversion of UInt64 based enums
filmor May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix enum codec 
A boxed enum value can't be casted directly to an integer, but using `System.Convert`
functions instead works fine.
  • Loading branch information
@filmor
filmor committed May 4, 2022
commit df3b569eb1f8da0524d1322139aab520918f2a1b
9 changes: 1 addition & 8 deletions src/runtime/Codecs/EnumPyIntCodec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,7 @@ public bool TryDecode<T>(PyObject pyObj, out T? value)
var enumType = value.GetType();
if (!enumType.IsEnum) return null;

try
{
return new PyInt((long)value);
}
catch (InvalidCastException)
{
return new PyInt((ulong)value);
}
return new PyInt(Convert.ToInt64(value));
}

private EnumPyIntCodec() { }
Expand Down