Move the type subscript implementation into ClassBase. #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues pythonnet#157 and pythonnet#128 by allowing the use of the type subscript operator on all types instead of just generic types, preventing the shadowing of generic types by a non-generic one like System.Action or System.EventHandler.
|
Note, that the Travis error is not related to this particular PR: https://travis-ci.org/pythonnet/pythonnet/jobs/111424039 |
|
@filmor thanks, I've restarted the travis builds - sometimes the nuget restore times out and running again should fix it. |
tonyroberts
added a commit
that referenced
this pull request
Feb 24, 2016
Move the type subscript implementation into ClassBase.
This was referenced Feb 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues #157 and #128 by allowing the use of the type
subscript operator on all types instead of just generic types,
preventing the shadowing of generic types by a non-generic one like
System.Action or System.EventHandler.