Skip to content

Drop Python 3.6 support #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Dec 30, 2021

What does this implement/fix? Explain your changes.

This drops official support for Python 3.6 which EOLed a week ago.

Does this close any currently open issues?

fixes #1640

Checklist

Check all those that are applicable and complete.

@filmor
Copy link
Member

filmor commented Jan 5, 2022

I personally don't want to do this for 3.0. There is no pressing need right now AFAICT, and keeping a slightly bigger overlap in the compatibility with 2.5 is a good thing.

@lostmsu
Copy link
Member Author

lostmsu commented Jan 5, 2022

@filmor it would still work, but won't be officially supported. Our CI runs would be slightly less wasteful.

If you look at NumPy, their drop support policy for new releases is much more aggressive. In fact, they already dropped support for 3.7 in new releases.

@lostmsu
Copy link
Member Author

lostmsu commented Jan 5, 2022

@mjmvisser what are Unity plans in regards to supported Python versions?

@lostmsu
Copy link
Member Author

lostmsu commented Apr 8, 2022

@filmor reconsider before 3.0? What's the overlap for? Unity was already on 3.7 at the time I sent this PR.

Most of the new packages releases on PyPi do not support 3.6 anymore. If people need legacy code, they can continue using 2.5.2.

@filmor
Copy link
Member

filmor commented Apr 9, 2022

I still don't see the point. It costs us nothing to keep the support around until we require a >= 3.7 feature.

@lostmsu
Copy link
Member Author

lostmsu commented Apr 9, 2022

@filmor and once we do, it would require a major version bump to drop support for 3.6 if we follow semver

@filmor
Copy link
Member

filmor commented Apr 9, 2022

What, why? I have never seen that logic practiced anywhere, see also https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api.

@lostmsu
Copy link
Member Author

lostmsu commented Apr 9, 2022

@filmor this might be OK on PyPi, but on NuGet pythonnet does not explicitly depend on Python, and I would consider supported Python version to be a part of public API.

Anyway, I am fine with keeping it. I just don't like the approach, when stuff is kept around without explicit justification. It is always "easy" to "just keep it around", but it is not a good justification on its own. Neither of the 3 active participants in pythonnet use 3.6 anymore.

@filmor
Copy link
Member

filmor commented May 23, 2022

Being stuck with old setuptools convinces me :)

@filmor filmor mentioned this pull request May 23, 2022
5 tasks
@filmor filmor closed this May 23, 2022
@lostmsu lostmsu deleted the bugs/1640 branch May 23, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.6 EOL is 23 Dec 2021. We should remove support for it in 3.0
2 participants