Temporary fix method binder for out parameters #1672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eirannejad, please add a test or two to cover the new code. |
lostmsu
reviewed
Jan 13, 2022
existing tests are passing bogus values to force matching the method signature these tests should pass with the recent method binder fix, without passing the bogus values
lostmsu
requested changes
Jan 14, 2022
|
(I'm a bit new to Github review/request change process. I apologize in advance if I clicked too many things) |
|
@eirannejad We'd need you to sign the .NET Foundation CLA: https://cla.dotnetfoundation.org/pythonnet/pythonnet @lostmsu Please have an eye on this for first-time contributors until the CLA bot is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Current method binder code needs cleanup. There is an active issue with pythonnet failing to find the appropriate overload when the method signature includes
outparameters e.g.SomeMethod(int a, out int b). Current workaround is to call the method by providing bogus value for theoutparameter e.g.SomeMethod(1, 0)instead ofSomeMethod(1)This PR pushes a temporary fix for this problem until the binder code is cleaned up. The change is intentionally minimal.
Does this close any currently open issues?
Not sure. Can not find anything related to this by looking at open issue titles
Any other comments?
No
Checklist
AUTHORSCHANGELOG