On shutdown from Python release all slot holders #1712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the old slots holder magic created by Amos. I think it is better, that skipping critical finalizers. This should make pythonnet/clr-loader#26 irrelevant. |
|
Looks like this does not work. I am going to investigate further. |
…e ones, that belong to managed types
5aa82ea to
5e041af
Compare
…anager is terminated and Python is shutting down
|
@filmor yeet! |
|
Nice :) Does it still work if you pull in 39db9f4? |
|
@filmor looks like it |
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Before this fix slots of reflected types were not released to Python defaults leaving Python referencing managed code after managed runtime has already shut down.
In the original bug, the runtime in question is Mono after
mono_jit_cleanupDoes this close any currently open issues?
#1683