method overloading fix for enum argument #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| TypeCode argtypecode = Type.GetTypeCode(pi[n].ParameterType); | ||
| Type typearg = Type.GetType("System." + argtypecode.ToString()); | ||
| if (typearg == clrtype) { | ||
| typematch = true; |
There was a problem hiding this comment.
Would comparing the type code of the parameter type and the clrtype be more appropriate here?
There was a problem hiding this comment.
@tonyroberts done! thanks for pointing out cleaner solution. I also added this "regression" test.
This was referenced Mar 15, 2016
Closed
tonyroberts
added a commit
that referenced
this pull request
Mar 17, 2016
method overloading fix for enum argument
|
@denfromufa great, thanks. |
|
a "dev2" release this week-end ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.