Take GIL when checking if error occurred on shutdown #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

filmor merged 1 commit into master from fix-shutdown-segfault

Jun 27, 2022

Member

filmor commented Jun 27, 2022

What does this implement/fix? Explain your changes.

Does this close any currently open issues?

Any other comments?

Supercedes #1832.

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Ensure you have signed the .NET Foundation CLA
Add yourself to AUTHORS
Updated the CHANGELOG


          Take GIL when checking if error occurred on shutdown

Member Author

filmor commented Jun 27, 2022

@BadSingleton I hope this PR works for you as well :)

filmor merged commit a49f3a8 into master

filmor deleted the fix-shutdown-segfault branch

June 27, 2022 09:45

Contributor

BadSingleton commented Jun 28, 2022

Yes, it does; this was the original form of my patch :) . Apologies for the lateness, it was a long weekend over here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet