Skip to content

Fix string construction #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

filmor
Copy link
Member

@filmor filmor commented Jul 8, 2022

What does this implement/fix? Explain your changes.

Since .NET strings are currently treated as "primitive" types (as they can not be constructed uninitialised, like other non-primitive types can), we only provide the "simple" constructor that converts a Python string or copies an existing String instance.

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Ensure you have signed the .NET Foundation CLA
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@filmor filmor mentioned this pull request Jul 8, 2022
23 tasks
@filmor filmor force-pushed the fix-string-construction branch from cdfedf1 to 24e5c7e Compare July 9, 2022 22:39
@filmor filmor force-pushed the fix-string-construction branch from 24e5c7e to 808fb0a Compare July 11, 2022 14:16
@filmor filmor marked this pull request as ready for review July 11, 2022 14:17
@filmor filmor changed the base branch from master to release July 11, 2022 14:17
@filmor filmor merged commit 60a719c into pythonnet:release Jul 11, 2022
@filmor filmor deleted the fix-string-construction branch July 11, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant