Skip to content

Fixed a leak in NewReference.Move #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Fixed a leak in NewReference.Move #1873

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59b1c51
Finalizer.Instance.Collect() and Runtime.TryCollectingGarbage(...) ar…
lostmsu Jul 14, 2022
469ec67
fixed leak in NewReference.Move
lostmsu Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixed leak in NewReference.Move 
fixes #1872
  • Loading branch information
@lostmsu
lostmsu committed Jul 14, 2022
commit 469ec671fc9d7ee2f149a6687b5c7aeb5f861563
2 changes: 1 addition & 1 deletion src/runtime/Native/NewReference.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public PyObject MoveToPyObject()
/// </summary>
public NewReference Move()
{
var result = new NewReference(this);
var result = DangerousFromPointer(this.DangerousGetAddress());
this.pointer = default;
return result;
}
Expand Down
14 changes: 14 additions & 0 deletions tests/test_constructors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"""Test CLR class constructor support."""

import pytest
import sys

import System

Expand Down Expand Up @@ -71,6 +72,19 @@ def test_default_constructor_fallback():
ob = DefaultConstructorMatching("2")


def test_constructor_leak():
from System import Uri
from Python.Runtime import Runtime

uri = Uri("http://www.python.org")
Runtime.TryCollectingGarbage(20)
ref_count = sys.getrefcount(uri)

# check disabled due to GC uncertainty
# assert ref_count == 1



def test_string_constructor():
from System import String, Char, Array

Expand Down