Disable implicit seq to array conversion when target type is object
#1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed unhandled Python errors during comparison attempts fixes pythonnet#1848
Additionally, fixes a type hint and makes sure that the new default behaviour is to use the environment variable if given.
- Only include src/runtime, no other .NET subproject - In particular, tests are not contained anymore in the sdist - Fix accidentally including obj and bin directories in the sdist
* Add unit tests for (U)IntPtr conversions * Special-case construction of (U)IntPtr * Check (U)IntPtr size explicitly
…e now callable from Python
Fixed a leak in `NewReference.Move`
…onnet#1878) also fixed issues with xml docs in the code implements pythonnet#1876
…ng sequence protocol to .NET arrays when the target .NET type is `System.Object`. The conversion is still attempted when the target type is a `System.Array` fixes pythonnet#1900
|
Wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Disabled implicit conversion from Python objects implementing sequence protocol to .NET arrays when the target .NET type is
System.Object. The conversion is still attempted when the target type is aSystem.Array.Many Python types implement sequence protocol. In many cases such conversion looses too much important data.
Does this close any currently open issues?
fixes #1900
Checklist
Check all those that are applicable and complete.
CHANGELOG