Added docstrings and minor refactoring #1926
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractus
commented
Aug 29, 2022
| if (op == Runtime.PyLongType) | ||
| return int32Type; | ||
|
|
||
| if (op == Runtime.PyLongType) |
There was a problem hiding this comment.
This block can never be reached so it's removed ; PyLongType maps to INT32_TYPE now
|
We will not accept any PRs with more formatting and renaming changes, than actual significant modifications to the code (e.g. new features or bug fixes). No code should be reformatted unless it is also touched for other purposes to preserve the ability to quickly look up its nature in git blame. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
ToManagedValuenow always go via theToManaged) - I expect no performance degradationDoes this close any currently open issues?
No - I started debugging a Numpy converter (as suggested in #1887) and ended up formatting this file; I will demonstrate the issue in another PR
Any other comments?
Some instruction to run the benchmarking would be useful (including the copy PythonRunTime.dll to the baseline folder; otherwise, build fails)
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG