Skip to content

Amended recent change to address issue #193 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Amended recent change to address issue #193 #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ def _find_msbuild_tool(tool="msbuild.exe", use_windows_sdk=False):
if use_windows_sdk:
sdks_root = r"SOFTWARE\Microsoft\Microsoft SDKs\Windows"
kits_root = r"SOFTWARE\Microsoft\Windows Kits\Installed Roots"
kits_suffix = "bin"
if PLATFORM == "x64":
kits_suffix += r"\x64"
kits_suffix = os.path.join("bin",PLATFORM)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space between comma and PLATFORM

keys_to_check.extend([
("Windows Kit 10.0", kits_root, "KitsRoot10", kits_suffix),
("Windows Kit 8.1", kits_root, "KitsRoot81", kits_suffix),
Expand Down