Skip to content

Config-less CoreCLR and improved runtime load message #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2022
Merged

Config-less CoreCLR and improved runtime load message #1942

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f12469
Bump clr-loader dependency to 0.2.3 and adjust interface
filmor Sep 16, 2022
db52dde
Improve error message if the runtime fails to load
filmor Sep 16, 2022
fd8fd3b
Fix manifest so we can build with python -m build
filmor Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve error message if the runtime fails to load
  • Loading branch information
@filmor
filmor committed Sep 17, 2022
commit db52ddef247cdc008bae18b5ad0fee2f1c690b21
39 changes: 28 additions & 11 deletions pythonnet/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ def set_runtime(runtime: Union[clr_loader.Runtime, str], **params: str) -> None:


def get_runtime_info() -> Optional[clr_loader.RuntimeInfo]:
"""Retrieve information on the configured runtime"""

if _RUNTIME is None:
return None
else:
Expand All @@ -52,22 +54,39 @@ def _get_params_from_env(prefix: str) -> Dict[str, str]:
def _create_runtime_from_spec(
spec: str, params: Optional[Dict[str, Any]] = None
) -> clr_loader.Runtime:
was_default = False
if spec == "default":
was_default = True
if sys.platform == "win32":
spec = "netfx"
else:
spec = "mono"

params = params or _get_params_from_env(spec)

if spec == "netfx":
return clr_loader.get_netfx(**params)
elif spec == "mono":
return clr_loader.get_mono(**params)
elif spec == "coreclr":
return clr_loader.get_coreclr(**params)
else:
raise RuntimeError(f"Invalid runtime name: '{spec}'")
try:
if spec == "netfx":
return clr_loader.get_netfx(**params)
elif spec == "mono":
return clr_loader.get_mono(**params)
elif spec == "coreclr":
return clr_loader.get_coreclr(**params)
else:
raise RuntimeError(f"Invalid runtime name: '{spec}'")
except Exception as exc:
if was_default:
raise RuntimeError(
f"""Failed to create a default .NET runtime, which would
have been "{spec}" on this system. Either install a
compatible runtime or configure it explicitly via
`set_runtime` or the `PYTHONNET_*` environment variables
(see set_runtime_from_env)."""
) from exc
else:
raise RuntimeError(
f"""Failed to create a .NET runtime ({spec}) using the
parameters {params}."""
) from exc


def set_runtime_from_env() -> None:
Expand All @@ -92,9 +111,7 @@ def set_runtime_from_env() -> None:
set_runtime(runtime)


def load(
runtime: Union[clr_loader.Runtime, str, None] = None, **params: str
) -> None:
def load(runtime: Union[clr_loader.Runtime, str, None] = None, **params: str) -> None:
"""Load Python.NET in the specified runtime

The same parameters as for `set_runtime` can be used. By default,
Expand Down