Skip to content

Update unmanaged exports #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2016
Merged

Conversation

den-run-ai
Copy link
Contributor

#95

@den-run-ai den-run-ai changed the title Update packages.config Update unmanaged exports May 27, 2016
@tonyroberts tonyroberts merged commit ec6ebd1 into pythonnet:master Jun 23, 2016
@tonyroberts
Copy link
Contributor

I had to fix the project file for this as well - it's not enough to just update packages.config. Please test your changes before creating pull requests and then pestering me to merge them.

@den-run-ai
Copy link
Contributor Author

Well, I tested locally and did not notice until later time, but had no
opportunity to correct this pull request at that time.
Can you show any comment where I asked to merge my unfinished pull
request(s)?
Sorry for pestering you, but other people were waiting for some fixes in
master and last time you replied was about 2 months ago.

On Thursday, June 23, 2016, Tony Roberts notifications@github.com wrote:

I had to fix the project file for this as well - it's not enough to just
update packages.config. Please test your changes before creating pull
requests and then pestering me to merge them.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#206 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHgZ5Vntx4gz200mYHevnT7xpM7MR4H4ks5qOkrNgaJpZM4IK8dh
.

@tonyroberts
Copy link
Contributor

Pull requests are a request for code to be pulled (hence the name). There is no need to comment requesting that the code be pulled, as that's the purpose of a pull request! Code that is not ready to be pulled should be worked on in your own fork, preferably in a topic branch if it's anything other than a simple change.

@matthid
Copy link
Contributor

matthid commented Jun 23, 2016

@tonyroberts people often use PRs to check the state of CI (I do occasionally as well) without the need to test on a linux system for example. They are often marked as WIP and give you the opportunity to comment / discuss early on.

@tonyroberts
Copy link
Contributor

Sure, I've no problem with that if clearly marked. I don't think that was the case here though, it was just something that didn't get picked up because the appveyor build didn't run. Personally, I have my own CI jobs set up against my own fork, but that's just my preference.

@den-run-ai den-run-ai deleted the patch-12 branch June 23, 2016 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants