Skip to content

Ensure that load only runs once #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Ensure that load only runs once #2079

merged 1 commit into from
Jan 18, 2023

Conversation

filmor
Copy link
Member

@filmor filmor commented Jan 17, 2023

What does this implement/fix? Explain your changes.

Fixes an oversight in that _LOADED was never set in pythonnet.load.

Does this close any currently open issues?

#2078

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Ensure you have signed the .NET Foundation CLA
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@filmor
Copy link
Member Author

filmor commented Jan 17, 2023

@lostmsu Could you have a look at what's going on on the ARM64 instance?

@lostmsu
Copy link
Member

lostmsu commented Jan 17, 2023

Seems GTG. Rebase and ARM branch should pass. Do not rerun this and older commits in CI, as one of the setup steps breaks the environment by upgrading setuptools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants