Use msbuild tools from PATH if available #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related: |
| @@ -22,6 +23,10 @@ | |||
|
|
|||
|
|
|||
| def _find_msbuild_tool(tool="msbuild.exe", use_windows_sdk=False): | |||
| path = find_executable(tool) | |||
There was a problem hiding this comment.
This should be below the docstring
There was a problem hiding this comment.
Oh my god how did that happen 😮 Silly me.
While _find_msbuild_tool searches in the registry to find the given build tool, it doesn't check if it's already in PATH. If one uses a developer command prompt to build, all necessary tools are in PATH. Fixes pythonnet#207 for me
3247415 to
35e3b28
Compare
|
@denfromufa I fixed the docstring issue. Can this be merged or is something else missing? |
|
@rnestler actually it is @tonyroberts who is merging pull requests for pythonnet. I'm ordinary contributor like you are :) |
|
@rnestler looks fine - but the Appveyor CI tests aren't working right now, so I need to fix that before I can merge this PR. |
|
@tonyroberts I activated AppVeyor CI on my fork. It seems to build fine there: https://ci.appveyor.com/project/rnestler/pythonnet/build/1.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While _find_msbuild_tool searches in the registry to find the given
build tool, it doesn't check if it's already in PATH.
If one uses a developer command prompt to build, all necessary tools are
in PATH.
Fixes #207 for me