Try to be strict around non-copyability #2440
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostmsu
reviewed
Aug 22, 2024
| @@ -103,5 +103,6 @@ public static PyFloat AsFloat(PyObject value) | |||
| public double ToDouble() => Runtime.PyFloat_AsDouble(obj); | |||
|
|
|||
| public override TypeCode GetTypeCode() => TypeCode.Double; | |||
| public override int GetHashCode() => ((PyObject)this).GetHashCode(); | |||
There was a problem hiding this comment.
This looks like it would just stackoverflow
| @@ -232,5 +232,6 @@ public string ToString(string format, IFormatProvider formatProvider) | |||
| } | |||
|
|
|||
| public override TypeCode GetTypeCode() => TypeCode.Int64; | |||
| public override int GetHashCode() => ((PyObject)this).GetHashCode(); | |||
Comment on lines
+86
to
+87
| var free = (delegate* unmanaged[Cdecl]<ref StolenReference, void>)freePtr; | ||
| free(ref ob); |
There was a problem hiding this comment.
I think this is wrong. It does not say anywhere but I'd expect tp_free to take a reference to PyObject (e.g. PyObject*), not a reference to reference to it (e.g. not a PyObject**).
There was a problem hiding this comment.
Ah, that's probably one reason for the crashes :)
|
Seems abandoned - requested changes not addressed. |
|
Not abandoned, just very low priority. We have to fix these warnings eventually, they are extremely spammy and the non-copyability check is borderline useless right now. Either we fix things or we drop the analyzer until an official one is added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.