Fix attribute setting #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9757cc to
5608d98
Compare
|
@denfromufa @vmuriart @tonyroberts Please review :) |
- When modifying attributes on a class, PyType_Modified has to be called - The result of a lookup may be non-NULL without being a descriptor (e.g. if we set it manually using `Class.attribute = 1`)
545ac02 to
d96d0a5
Compare
|
One minor (additional) change in the last push: I changed it to call |
|
@tonyroberts Is that a formal approval? ;) |
|
@filmor haha I thought of it as a 'formal' approval, but I agree with the changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set it manually using
Class.attribute = 1)Fixes issue #292