Addresses issue #261 with providing more detail information missing d… #298

fdanny · 2016-12-01T21:15:30Z

This addresses issue #261 to provide more information when there is a missing assembly dependency. The logic basically does the following

After importing module check if an ImportError exception occured
If it does load the assembly dependencies and try to load each one
if I can't load that assembly I add to the list
At the end I display the list of missing assemblies.

…missing dependencies with ImportError Exceptions

den-run-ai · 2016-12-01T21:35:53Z

@fdanny can you please add some tests? i.e. you can look at test_import.py file.

fdanny · 2016-12-01T22:35:56Z

@denfromufa Yup. I can do that. The way I tested it I created a dll that had a missing dependency. I made assure my ImportError Exception contained the specific missing dependency. Is this something that you were thinking?

den-run-ai · 2016-12-02T00:25:46Z

Yes, that's right!

…

On Thu, Dec 1, 2016, 4:35 PM fdanny ***@***.***> wrote: @denfromufa <https://github.com/denfromufa> Yup. I can do that. The way I tested it I created a dll that had a missing dependency. I made assure my ImportError Exception contained the specific missing dependency. Is this something that you were thinking? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#298 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgZ5YsE4jQuzGb5kQDIvm6IfkH2FZ7Uks5rD0vNgaJpZM4LB5fw> .

… dependency

den-run-ai

Can you make TestDependencyAssembly.dll compile as part of project and remove its dependencies before import? Just including a binary without source code is not maintainable.

fdanny · 2016-12-02T13:21:55Z

@denfromufa Is there a location in the solution you want me to put this in TestDependencyAssembly? Is it okay just to check the solution as a reference and treat this dll as a resource. If there are any changes needed then the source code is included to build

Also why did my test failed on the Travis CI but passed AppVeyor? It has the following error
clr.AddReference(path_to_dll)
System.IO.FileNotFoundException: Unable to find assembly

den-run-ai · 2016-12-04T07:09:54Z

You can just add a new project to solution. Otherwise just compile at
runtime - have a look at clrmagic.

That dll loading issue is pretty weird, please share the source code and
how you compiled it.

Here is repeatable issue using Mono C# REPL when using reflection, but not
when adding reference (LoadAssembly):


Mono C# Shell, type "help;" for help


Enter statements below.

csharp>
LoadAssembly("/home/dta/Documents/clrmagic/TestDependencyAssembly.dll")

csharp> using System.Reflection;

csharp> Assembly

Assembly AssemblyAlgorithmIdAttribute AssemblyCompanyAttribute
AssemblyConfigurationAttribute AssemblyContentType
AssemblyCopyrightAttribute AssemblyCultureAttribute
AssemblyDefaultAliasAttribute AssemblyDelaySignAttribute
AssemblyDescriptionAttribute AssemblyFileVersionAttribute
AssemblyFlagsAttribute AssemblyInformationalVersionAttribute
AssemblyKeyFileAttribute AssemblyKeyNameAttribute AssemblyLoadEventArgs
AssemblyLoadEventHandler AssemblyMetadataAttribute AssemblyName
AssemblyNameFlags AssemblyNameProxy AssemblyProductAttribute
AssemblySignatureKeyAttribute AssemblyTitleAttribute
AssemblyTrademarkAttribute AssemblyVersionAttribute

csharp> Assembly testdll =
Assembly.Load("/home/dta/Documents/clrmagic/TestDependencyAssembly.dll")

System.IO.FileNotFoundException: Could not load file or assembly
'/home/dta/Documents/clrmagic/TestDependencyAssembly.dll' or one of its
dependencies

File name: '/home/dta/Documents/clrmagic/TestDependencyAssembly.dll'

  at System.AppDomain.Load (System.String assemblyString,
System.Security.Policy.Evidence assemblySecurity, Boolean refonly)
<0x7f976292e650 + 0x000a2> in <filename unknown>:0

  at System.AppDomain.Load (System.String assemblyString) <0x7f976292e610 +
0x00015> in <filename unknown>:0

  at (wrapper remoting-invoke-with-check) System.AppDomain:Load (string)

  at System.Reflection.Assembly.Load (System.String assemblyString)
<0x7f97629a1980 + 0x0001b> in <filename unknown>:0

  at <InteractiveExpressionClass>.Host (System.Object& $retval) <0x41b71120
+ 0x0001a> in <filename unknown>:0

  at Mono.CSharp.Evaluator.Evaluate (System.String input, System.Object&
result, System.Boolean& result_set) <0x41ae4d30 + 0x000dd> in <filename
unknown>:0

  at Mono.CSharpShell.Evaluate (System.String input) <0x41ae4c30 + 0x00053>
in <filename unknown>:0

csharp> Assembly testdll =
Assembly.Load("/home/dta/Documents/clrmagic/TestDependencyAssembly")

System.IO.FileNotFoundException: Could not load file or assembly
'/home/dta/Documents/clrmagic/TestDependencyAssembly' or one of its
dependencies

File name: '/home/dta/Documents/clrmagic/TestDependencyAssembly'

  at System.AppDomain.Load (System.String assemblyString,
System.Security.Policy.Evidence assemblySecurity, Boolean refonly)
<0x7f976292e650 + 0x000a2> in <filename unknown>:0

  at System.AppDomain.Load (System.String assemblyString) <0x7f976292e610 +
0x00015> in <filename unknown>:0

  at (wrapper remoting-invoke-with-check) System.AppDomain:Load (string)

  at System.Reflection.Assembly.Load (System.String assemblyString)
<0x7f97629a1980 + 0x0001b> in <filename unknown>:0

  at <InteractiveExpressionClass>.Host (System.Object& $retval) <0x41b71690
+ 0x0001a> in <filename unknown>:0

  at Mono.CSharp.Evaluator.Evaluate (System.String input, System.Object&
result, System.Boolean& result_set) <0x41ae4d30 + 0x000dd> in <filename
unknown>:0

  at Mono.CSharpShell.Evaluate (System.String input) <0x41ae4c30 + 0x00053>
in <filename unknown>:0

csharp>

fdanny · 2016-12-06T04:31:10Z

@denfromufa I ran into an issue trying to resolve this. My method will only work if the namespace imported is the same as the assembly name. I have no way of mapping a namespace to an assembly.

It looks like when clr.AddReference is called an AssemblyLoadEventHandle is initiated when an assembly is loaded and eventually goes into the AssemblyManager::ScanAssembly. It looks like this method parses out the namespaces and loads it into ConcurrentDictionary.

The issue in ScanAssembly is when
types = assembly.GetTypes();

This doesn't work since it doesn't have all the dependencies so we don't get the namespace mapping.

I'm thinking the following maybe

Raise an exception clr.AddReference if not all dependencies are present
On a failure on assembly.GetTypes() Read the assembly in Stream and parse the out the information sort of like Mono Cecil.

What do you think???

den-run-ai · 2016-12-07T07:17:33Z

@fdanny maybe it is ok without namespace in the error message? but i'm surprised that it is hard to track it down.

vmuriart · 2017-02-07T01:07:38Z

@denfromufa @fdanny is there any help needed for this pull request ?

den-run-ai · 2017-02-07T02:53:38Z

@fdanny needs help tracking down the namespace name in the Exception traceback

…ore info when CLR assemblies are failed to be loaded 1. When trying to implicitly load assemblies, and that fails NOT because an assembly is missing, but because loading failed for some reason, emit Python warning. 2. When trying to import a module in our import hook, if the module name is an assembly name, and we fail to load it, and Python also fails to find a module with the same name, add the exceptions we got during the attempt to load it into __cause__ of the final ImportError BREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException. Additional: a few uses of BorrowedReference This addresses pythonnet#261 It is an alternative to pythonnet#298

…ore info when CLR assemblies are failed to be loaded 1. When trying to implicitly load assemblies, and that fails NOT because an assembly is missing, but because loading failed for some reason, emit Python warning. 2. When trying to import a module in our import hook, if the module name is an assembly name, and we fail to load it, and Python also fails to find a module with the same name, add the exceptions we got during the attempt to load it into __cause__ of the final ImportError BREAKING: clr.AddReference will now throw exceptions besides FileNotFoundException. Additional: a few uses of BorrowedReference This addresses #261 It is an alternative to #298

filmor · 2021-02-15T08:08:37Z

The alternative PR #1076 was merged a while ago.

Addresses issue pythonnet#261 with providing more detail information …

6984ee2

…missing dependencies with ImportError Exceptions

Daniel Fernandez added 2 commits December 1, 2016 22:25

Added unit test for fix for pythonnet#261 added .NET DLL with missing…

21f8a1b

… dependency

Add C# dll to test missing dependency ImportError

6c8c63c

den-run-ai reviewed Dec 2, 2016

View reviewed changes

den-run-ai mentioned this pull request Apr 4, 2017

import error is not reported #111

Closed

den-run-ai added the waiting for user feedback label Apr 21, 2017

filmor added this to the 2.4.0 milestone Aug 30, 2018

filmor modified the milestones: 2.4.0, 2.5.0 May 8, 2019

lostmsu mentioned this pull request Mar 4, 2020

Provide more info about failuers to load CLR assemblies #1076

Merged

2 tasks

lostmsu removed this from the 2.5.0 milestone Apr 23, 2020

filmor closed this Feb 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addresses issue #261 with providing more detail information missing d… #298

Addresses issue #261 with providing more detail information missing d… #298

fdanny commented Dec 1, 2016

den-run-ai commented Dec 1, 2016

fdanny commented Dec 1, 2016

den-run-ai commented Dec 2, 2016 via email

den-run-ai left a comment •

edited

Loading

fdanny commented Dec 2, 2016 •

edited

Loading

den-run-ai commented Dec 4, 2016

fdanny commented Dec 6, 2016 •

edited

Loading

den-run-ai commented Dec 7, 2016

vmuriart commented Feb 7, 2017

den-run-ai commented Feb 7, 2017

filmor commented Feb 15, 2021

Addresses issue #261 with providing more detail information missing d… #298

Addresses issue #261 with providing more detail information missing d… #298

Conversation

fdanny commented Dec 1, 2016

den-run-ai commented Dec 1, 2016

fdanny commented Dec 1, 2016

den-run-ai commented Dec 2, 2016 via email

den-run-ai left a comment • edited Loading

Choose a reason for hiding this comment

fdanny commented Dec 2, 2016 • edited Loading

den-run-ai commented Dec 4, 2016

fdanny commented Dec 6, 2016 • edited Loading

den-run-ai commented Dec 7, 2016

vmuriart commented Feb 7, 2017

den-run-ai commented Feb 7, 2017

filmor commented Feb 15, 2021

den-run-ai left a comment •

edited

Loading

fdanny commented Dec 2, 2016 •

edited

Loading

fdanny commented Dec 6, 2016 •

edited

Loading