Refactor directives #324
Merged
Refactor directives #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes code more future proof as new python versions role out. We could otherwise use !PYTHON27 but it could be confused as a patch specific to that version of python instead of PYTHON3 compat.
Go with general convention
Not relevant after dropping Python 24, Python 25
filmor
approved these changes
Jan 12, 2017
|
@vmuriart so now we need to use both python3 and python3x flags? |
|
Yes. And .NET doesn't really have a way around that, AFAICT. |
|
@vmuriart is it also possible to do this at the top of the file: |
|
It would be needed across every file that needs that directive. http://stackoverflow.com/questions/30350738/where-to-specify-preprocessor-directives-in-visual-studio The project file is updated to have PYTHON2 set on it though, you would just need to update that on your build config to PYTHON3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors all those pesky #if to simplify process of supporting newer python versions.
Theres a section in runtime I left untouched as it has many embbded directives.