Skip to content

Improve tests #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Improve tests #341

wants to merge 5 commits into from

Conversation

filmor
Copy link
Member

@filmor filmor commented Jan 30, 2017

What does this implement/fix? Explain your changes.

  • Simplifies testing by giving the test DLL access to the internals of Python.Runtime
  • Update NUnit to 3.5

Does this close any currently open issues?

Nope.

Any other comments?

Can be squashed.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

All N/A.

@codecov-io
Copy link

codecov-io commented Jan 30, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@f4d83cf).


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d83cf...67e1b8f. Read the comment docs.

@vmuriart
Copy link
Contributor

Is the update to nunit3.5 required ? Opencover was a pain to setup with nunit2 (though now I see why you didn't want me freezing the version :-) )

@vmuriart vmuriart mentioned this pull request Jan 30, 2017
vmuriart added a commit that referenced this pull request Jan 30, 2017
@vmuriart vmuriart self-requested a review January 30, 2017 22:57
@vmuriart
Copy link
Contributor

Merged on master

@vmuriart vmuriart closed this Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants